Skip to content

Conversation

@kazimuth
Copy link
Contributor

@kazimuth kazimuth commented Feb 7, 2024

Description of Changes

  • Rename tables in benchmarks to describe their contents
  • Make parameter names uniform between callgrind and criterion
  • Disable stdb_module benchmarks on CI (too noisy)

This wants to be paired with https://github.com/clockworklabs/benchmarks-viewer/pull/2, which reworks some things about benchmark reports.

I'm considering disabling the in memory benchmarks entirely on CI, but haven't done that yet. Changing the benchmark report format may make them easier to read, so that that isn't necessary.

Expected complexity level and risk

1

@bfops bfops added release-any To be landed in any release window no runtime change This change does not affect the final binaries labels Feb 8, 2024
@kazimuth kazimuth force-pushed the kazimuth/bench_cleanup branch from 0dc1db3 to e1f99ea Compare February 15, 2024 18:12
@kazimuth
Copy link
Contributor Author

Merging this, I've successfully pulled the data out and it works correctly.

@kazimuth kazimuth added this pull request to the merge queue Feb 16, 2024
@kazimuth kazimuth removed this pull request from the merge queue due to a manual request Feb 16, 2024
@kazimuth kazimuth added this pull request to the merge queue Feb 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 16, 2024
@kazimuth kazimuth force-pushed the kazimuth/bench_cleanup branch from 6d553bc to 95d8aee Compare February 23, 2024 20:01
@kazimuth kazimuth force-pushed the kazimuth/bench_cleanup branch from 95d8aee to bcf6349 Compare February 23, 2024 20:10
@kazimuth kazimuth enabled auto-merge February 23, 2024 20:26
@kazimuth kazimuth added this pull request to the merge queue Feb 23, 2024
Merged via the queue into master with commit a0a18dd Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no runtime change This change does not affect the final binaries release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants